[webkit-reviews] review denied: [Bug 49686] Converge means of querying a parent node into one way, which is Node::parentNode. : [Attachment 74178] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 49686: Converge means of querying a parent node into one way, which is
Node::parentNode.
https://bugs.webkit.org/show_bug.cgi?id=49686

Attachment 74178: Patch
https://bugs.webkit.org/attachment.cgi?id=74178&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74178&action=review

review- because EWS says XSLTProcessorQt.cpp still has some calls to parent in
it and ...

> WebCore/dom/Node.h:658
> +    ContainerNode* parent() const { return
TreeShared<ContainerNode>::parent(); }

A cleaner way of doing this is with a using declaration:

    using TreeShared<ContainerNode>::parent;

That way you don’t introduce a new inline function, just change the visibility
of the existing function.

I think this also deserves a comment. It’s not clear why the function is
private without a comment.