[webkit-reviews] review granted: [Bug 49090] WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning : [Attachment 73123] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 49090: WebProcess won't kill itself if UIProcess goes away while WebProcess
is spinning
https://bugs.webkit.org/show_bug.cgi?id=49090

Attachment 73123: Patch
https://bugs.webkit.org/attachment.cgi?id=73123&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73123&action=review

> WebKit2/Platform/CoreIPC/Connection.h:83
> +	   virtual void didCloseOnConnectionWorkQueue(WorkQueue*, Connection*)
{ }

Why not pure virtual?

> WebKit2/Platform/WorkItem.h:174
> +    void execute()

Is this virtual? Could you be explicit about that?