[webkit-reviews] review granted: [Bug 49004] Enable running of Qt API tests on BuildBot : [Attachment 72949] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 49004: Enable running of Qt API tests on BuildBot
https://bugs.webkit.org/show_bug.cgi?id=49004

Attachment 72949: proposed patch
https://bugs.webkit.org/attachment.cgi?id=72949&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72949&action=review

Otherwise LGTM, r=me with these changes.
Bill, could you execute a reconfigure on buildbot master after this patch
landed?

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337
> +    def evaluateCommand(self, cmd):
> +	   if self.incorrectLines:
> +	       return FAILURE

Qt API tests are quite stable, but I think 
we shouldn't block the bots if it fails.

I prefer using WARNINGS instead of FAILURE.

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:342
> +	   if cmd.rc != 0:
> +	       return FAILURE
> +
> +	   return SUCCESS

Ditto.