[webkit-reviews] review granted: [Bug 49033] webkitpy.common.system.executive_unittest fails when run with Win32 Python : [Attachment 73070] Addresses comments from Dave and Eric

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 49033: webkitpy.common.system.executive_unittest fails when run with Win32
Python
https://bugs.webkit.org/show_bug.cgi?id=49033

Attachment 73070: Addresses comments from Dave and Eric
https://bugs.webkit.org/attachment.cgi?id=73070&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73070&action=review

In general this looks fine.  You probalby want a version check where dave
noted.

> WebKitTools/Scripts/webkitpy/common/system/executive.py:341
> +	   if sys.platform == 'win32' and versioning.compare_version(sys,
'3.0')[0] < 0:

Seems like Chris's versioning module is a bit hard to use.  The whole neeing to
grab [0]  and compare it < 0, seems really awkward.

We should probably make his module better, eventually.