[webkit-reviews] review denied: [Bug 37515] getPathSegAtLength() gives incorrect value : [Attachment 55515] 5th patch, fixed that warning.

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied  review:
Bug 37515: getPathSegAtLength() gives incorrect value
https://bugs.webkit.org/show_bug.cgi?id=37515

Attachment 55515: 5th patch, fixed that warning.
https://bugs.webkit.org/attachment.cgi?id=55515&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hey Eric,

I just saw that you have already set r+, I'm taking it back to r-, because of
two issues:
WebCore/svg/SVGPathSegList.cpp:60
 +	traversalState.m_desiredLength = static_cast<float>length;
How can this compile? Missing paranthesis, it should be:
static_cast<float>(length).
Second issue: We should not just cast double to float, but instead use
"narrowPrecisionToFloat".

Please upload a revised version.