[webkit-reviews] review requested: [Bug 31018] Accessibility: Implement isSelected in DRT for GTK : [Attachment 55526] Patch to fix this bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 01:12:58 PDT 2010


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 31018: Accessibility: Implement isSelected in DRT for GTK
https://bugs.webkit.org/show_bug.cgi?id=31018

Attachment 55526: Patch to fix this bug
https://bugs.webkit.org/attachment.cgi?id=55526&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #7)
> (From update of attachment 55268 [details])
> Actually, we don't do c-style forward declarations of variables.  Please
declare them inline.

Done.

(In reply to comment #6)
> (From update of attachment 55268 [details])
> LGTM.
> 
> Don't we have some sort of GRefPtr so we don't have to manually call
g_object_unref?

I'm not sure that would be aplicable on here, since the extra ref comes from
ATK lib, but not a strong opinion anyway. Glad to hear suggestions :-)


More information about the webkit-reviews mailing list