[webkit-reviews] review denied: [Bug 38750] [Chromium] StorageNamespaceProxy should pass quota argument for SessionStorage : [Attachment 55377] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied hans at chromium.org's request for
review:
Bug 38750: [Chromium] StorageNamespaceProxy should pass quota argument for
SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=38750

Attachment 55377: Patch
https://bugs.webkit.org/attachment.cgi?id=55377&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Didn't you mean to commit-queue+ this?


> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index
039cd6c8cf40225242ab5e344228330c25ff298a..f524215c85002614593e2d1f2bc09fa3bef93
f91 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-05-07  Hans Wennborg  <hans at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Chromium] StorageNamespaceProxy should pass quota argument for
SessionStorage
> +	   https://bugs.webkit.org/show_bug.cgi?id=38750

Please explain why you're doing this and maybe a high level of what you're
doing.

> +
> +	   * public/WebStorageNamespace.h:
> +	   * public/WebViewClient.h:
> +	   (WebKit::WebViewClient::createSessionStorageNamespace):
> +	   * src/StorageNamespaceProxy.cpp:
> +	   (WebCore::StorageNamespace::sessionStorageNamespace):
> +
>  2010-05-06  Pavel Feldman  <pfeldman at chromium.org>
>  
>	   Reviewed by Timothy Hatcher.
> diff --git a/WebKit/chromium/public/WebStorageNamespace.h
b/WebKit/chromium/public/WebStorageNamespace.h
> index
4b648d43a63622dd5b149af588715879ee1f403a..df9feaaeee11a6e89391d7287de5214ae49ae
f8e 100644
> --- a/WebKit/chromium/public/WebStorageNamespace.h
> +++ b/WebKit/chromium/public/WebStorageNamespace.h
> @@ -49,11 +49,22 @@ public:
>      // object when you're finished.
>      WEBKIT_API static WebStorageNamespace* createLocalStorageNamespace(const
WebString& backingDirectoryPath, unsigned quota);
>      WEBKIT_API static WebStorageNamespace*
createSessionStorageNamespace(unsigned quota);
> +
> +    // FIXME(hans) Remove this when Chromium is rolled and all callers pass

// FIXME:Remove this ....

> +    // the quota argument.

Don't line wrap.

>      WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace()
>      {
>	   return createSessionStorageNamespace(noQuota);
>      }
>  
> +    // The quota for each storage area.  Suggested by the spec.
> +    static const unsigned m_localStorageQuota = 5 * 1024 * 1024;
> +
> +    // Since SessionStorage memory is allocated in the browser process, we
place a
> +    // per-origin quota on it.  Like LocalStorage there are known attacks
against
> +    // this, so it's more of a sanity check than a real security measure.
> +    static const unsigned m_sessionStorageQuota = 5 * 1024 * 1024;
> +
>      static const unsigned noQuota = UINT_MAX;
>  
>      virtual ~WebStorageNamespace() { }
> diff --git a/WebKit/chromium/public/WebViewClient.h
b/WebKit/chromium/public/WebViewClient.h
> index
98e048593658f8bb97d8ed48a604f6cf3ad98679..749f559061430c67608f307aa0ade250c6ace
6d1 100644
> --- a/WebKit/chromium/public/WebViewClient.h
> +++ b/WebKit/chromium/public/WebViewClient.h
> @@ -81,6 +81,10 @@ public:
>      virtual WebWidget* createPopupMenu(const WebPopupMenuInfo&) { return 0;
}
>  
>      // Create a session storage namespace object associated with this
WebView.
> +
> +    // FIXME(hans) This is needed while subclasses implement the method
without

ditto

> +    // the quota parameter but callers inside WebKit pass a quota argument.

ditto