[webkit-reviews] review granted: [Bug 16258] Web Inspector should highlight when clicking a node's closing tag : [Attachment 51740] [PATCH] Removed an odd method
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 28 05:26:23 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 16258: Web Inspector should highlight when clicking a node's closing tag
https://bugs.webkit.org/show_bug.cgi?id=16258
Attachment 51740: [PATCH] Removed an odd method
https://bugs.webkit.org/attachment.cgi?id=51740&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +WebInspector.ElementsTreeElement = function(node, elementCloseTag)
Please merge it carefully with Joe's changes.
> {
> - var hasChildrenOverride = node.hasChildNodes() &&
!this._showInlineText(node);
> + this.elementCloseTag = elementCloseTag;
Private?
> - if (this._expandedChildrenLimit === x)
> + if (this._expandedChildrenLimit === x || this.elementCloseTag)
Why this change?
More information about the webkit-reviews
mailing list