[webkit-reviews] review granted: [Bug 36612] Web Inspector: don't crash when there are messages in console from previous iframe content : [Attachment 51749] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 36612: Web Inspector: don't crash when there are messages in console from
previous iframe content
https://bugs.webkit.org/show_bug.cgi?id=36612

Attachment 51749: patch
https://bugs.webkit.org/attachment.cgi?id=51749&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with comments. please fix prior to landing.

> +CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL
http://localhost:8000/inspector-enabled/resources/console-log-frame-after-navig
ation.html from frame with URL
http://127.0.0.1:8000/inspector-enabled/resources/console-log-frame-before-navi
gation.html. Domains, protocols and ports must match.

I am not sure this will be an exact match on all platforms including chromium.
Please test that.

> +InjectedScript._toString = function(obj)
> +{
> +    // We don't use String(obj) because inspectedWindow.String is undefined
if owning frame navigated to another page.
> +    return "" + obj;

This looks like a hack. Does it happen in both engines? Should you file a bug
against it and put fixme here? Otherwise looks like total hack.