[webkit-reviews] review granted: [Bug 36613] Web Inspector: Cover the Audits panel with tests : [Attachment 51754] [PATCH] Full results tree dump in the test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 28 05:15:38 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 36613: Web Inspector: Cover the Audits panel with tests
https://bugs.webkit.org/show_bug.cgi?id=36613

Attachment 51754: [PATCH] Full results tree dump in the test
https://bugs.webkit.org/attachment.cgi?id=51754&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Couple of nits you should fix prior to landing:
- WebInspector.displayNameForURL is now test-friendly, no need to work around
it
- You should try adding line breaks into the results dump as I do it for styles
and elements tree for example.


More information about the webkit-reviews mailing list