[webkit-reviews] review denied: [Bug 36487] Refactoring: HTMLFormControlElement should not have redundant null check : [Attachment 51413] a small change for cleanup

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 36487: Refactoring: HTMLFormControlElement should not have redundant null
check
https://bugs.webkit.org/show_bug.cgi?id=36487

Attachment 51413: a small change for cleanup
https://bugs.webkit.org/attachment.cgi?id=51413&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The changes to HTMLFormControlElement::dispatchFocusEvent and
HTMLFormControlElement::dispatchBlurEvent are OK. Not a great improvement, but
nice to use the Document::page helper function to save a little code.

The changes to HTMLCanvasElement::convertLogicalToDevice and
HTMLCanvasElement::convertLogicalToDevice are different though. Those are
adding a null check of Page*. Presumably, this is a bug fix. Before, there
would be a crash if the page was zero. That means we need to construct a test
case to demonstrate that crash, and that the crash is fixed.

review-