[webkit-reviews] review granted: [Bug 36458] DOMCoreException needs NoStaticTables modifier : [Attachment 51373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 13:55:25 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 36458: DOMCoreException needs NoStaticTables modifier
https://bugs.webkit.org/show_bug.cgi?id=36458

Attachment 51373: Patch
https://bugs.webkit.org/attachment.cgi?id=51373&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Renaming may make sense - DOMCoreException is just an internal name for WebKit,
and I suspect that it was chosen simply to avoid file name conflicts. On the
other hand, it's still DOMException, so hiding that fact under a different name
would be confusing.

r=me with the understanding that this will be covered by regression tests soon.


More information about the webkit-reviews mailing list