[webkit-reviews] review canceled: [Bug 36375] Worker's onerror handler should accept ErrorEvent as only argument instead of three arguments : [Attachment 51425] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 13:57:24 PDT 2010


Dmitry Titov <dimich at chromium.org> has canceled Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 36375: Worker's onerror handler should accept ErrorEvent as only argument
instead of three arguments
https://bugs.webkit.org/show_bug.cgi?id=36375

Attachment 51425: patch
https://bugs.webkit.org/attachment.cgi?id=51425&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Good catch Jian! I didn't realize as well the Workers simply 'borrow' the
onerror attribute semantics from 'window', for consistency. The spec could have
been more explicit on this. Indeed, it seems the spec still implies the
3-argument function should be a value of the onerror attribute of a global
scope object.
Yury, could you please clarify this? I'm removing r? from the patch for now..


More information about the webkit-reviews mailing list