[webkit-reviews] review denied: [Bug 36328] Missing plug-ins should be represented by text only, instead of lego block : [Attachment 51300] Add code to draw a subtle rounded rectangle containing the text "Missing Plug-in"

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kevin Decker
<kdecker at apple.com>'s request for review:
Bug 36328: Missing plug-ins should be represented by text only, instead of lego
block
https://bugs.webkit.org/show_bug.cgi?id=36328

Attachment 51300: Add code to draw a subtle rounded rectangle containing the
text "Missing Plug-in"
https://bugs.webkit.org/attachment.cgi?id=51300&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: rendering/RenderEmbeddedObject.h
> ===================================================================
> --- rendering/RenderEmbeddedObject.h	(revision 56339)
> +++ rendering/RenderEmbeddedObject.h	(working copy)
> @@ -34,12 +34,15 @@
>      virtual ~RenderEmbeddedObject();
>  
>      void updateWidget(bool onlyCreateNonNetscapePlugins);
> +    void setShowsMissingPluginIndicator() { m_showsMissingPluginIndicator =
true; }

This needs an associated getter (which should be const).

> +    void paint(PaintInfo& paintInfo, int tx, int ty);

I think you should override paintReplaced.

>  private:
> +    bool m_showsMissingPluginIndicator;

Please put this after the private methods.

r- because it should override paintReplaced().