[webkit-reviews] review denied: [Bug 26396] Percentage top value on position:relative descendant not resolved correctly if containing block height is not specified explicitly : [Attachment 49194] Another version of patch, try to make the bots happy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 10:34:10 PDT 2010


Adam Barth <abarth at webkit.org> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 26396: Percentage top value on position:relative descendant not resolved
correctly if containing block height is not specified explicitly
https://bugs.webkit.org/show_bug.cgi?id=26396

Attachment 49194: Another version of patch, try to make the bots happy
https://bugs.webkit.org/attachment.cgi?id=49194&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Sorry for the delay in reviewing your patch.  The comments added in this patch
are redundant with the code that they describe.  Please either remove the
comments or replace them with the "why" of the code instead of the "how."

As mentioned in the comments above, we need one of our CSS folks to review the
technical content of this patch.  You might find some of those folks by seeing
who in <https://trac.webkit.org/wiki/WebKit%20Team> has "CSS" listed next to
their name.


More information about the webkit-reviews mailing list