[webkit-reviews] review requested: [Bug 33453] [Qt] MediaPlayerPrivate: expose supported types to WebCore : [Attachment 51301] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 10:25:14 PDT 2010


Jakub Wieczorek <jwieczorek at webkit.org> has asked  for review:
Bug 33453: [Qt] MediaPlayerPrivate: expose supported types to WebCore
https://bugs.webkit.org/show_bug.cgi?id=33453

Attachment 51301: patch
https://bugs.webkit.org/attachment.cgi?id=51301&action=review

------- Additional Comments from Jakub Wieczorek <jwieczorek at webkit.org>
OK, one more try with this patch.

It's the same as the last version except that it doesn't unskip all the media
tests: just two that only cover what we are fixing here and are stable enough.
The rest is just too flakey when running in a group, they either time out or
crash and I couldn't track it down. Possibly still many of the tests can be
safely unskipped, but I'll just leave it for another patch.
Hopefully the tests can perform better with the new media backend.

Simon, can you please have a look once again? Thanks.


More information about the webkit-reviews mailing list