[webkit-reviews] review denied: [Bug 36438] Use "-f" option instead of "--force" for git rm. : [Attachment 51274] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 36438: Use "-f" option instead of "--force" for git rm.
https://bugs.webkit.org/show_bug.cgi?id=36438

Attachment 51274: proposed patch
https://bugs.webkit.org/attachment.cgi?id=51274&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Lame.  We should document what minimum version of git scm.py and this file are
expected to support.

This change also needs a comment explaining why it's -f so that someone doesn't
later change it back to --force.

Can we unit test this?	I guess not easily given the current design of the perl
scripts.

r- mostly because this needs a comment/further documentation in the file, and I
don't believe this is a full fix (does scm.py need a similar fix?)