[webkit-reviews] review granted: [Bug 38142] RegExp caching : [Attachment 58772] RegExp caching
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 22 11:41:34 PDT 2010
Geoffrey Garen <ggaren at apple.com> has granted Renata Hodovan
<hodovan.renata at stud.u-szeged.hu>'s request for review:
Bug 38142: RegExp caching
https://bugs.webkit.org/show_bug.cgi?id=38142
Attachment 58772: RegExp caching
https://bugs.webkit.org/attachment.cgi?id=58772&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
JavaScriptCore/runtime/RegExpCache.cpp:65
+ m_cacheMap.set(key, regExp);
You could eliminate this hash lookup by passing an iterator from
lookupOrCreate. I think that would be a good thing to do in a follow-up patch.
r=me
More information about the webkit-reviews
mailing list