[webkit-reviews] review granted: [Bug 41000] AX: If an element that is a continuation is removed, its parent tree is not notified appropriately that their children have changed : [Attachment 59396] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 41000: AX: If an element that is a continuation is removed, its parent tree
is not notified appropriately that their children have changed
https://bugs.webkit.org/show_bug.cgi?id=41000

Attachment 59396: Patch
https://bugs.webkit.org/attachment.cgi?id=59396&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // Go up the accessibility parent chain, but only if the element already
exists. Creating an AX element now can be fatal.

Is there some better way to say that than "can be fatal"? Maybe say more
specifically what's bad about creating an AX element now?

> -		   axObjectCache()->postNotification(renderParent,
AXObjectCache::AXLiveRegionChanged, true);
> +		   axObjectCache()->postNotification(axParent->renderer(),
AXObjectCache::AXLiveRegionChanged, true);

Is axParent->renderer() guaranteed to be non-zero?

r=me