[webkit-reviews] review granted: [Bug 40968] Make PendingScript hold a CachedResourceClient open for its lifetime : [Attachment 59370] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 22 11:51:58 PDT 2010


Eric Seidel <eric at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40968: Make PendingScript hold a CachedResourceClient open for its lifetime
https://bugs.webkit.org/show_bug.cgi?id=40968

Attachment 59370: Patch
https://bugs.webkit.org/attachment.cgi?id=59370&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM!  Note, no need for argument names when they don't add anything ( 78      
  void setCachedScript(CachedScript* cachedScript);
)

No need to change it here though.  We really need you to have commit-bit so
nits are easier to fix on landing. :)


More information about the webkit-reviews mailing list