[webkit-reviews] review requested: [Bug 35350] DumpRenderTree should allow tests with modal dialogs : [Attachment 59319] Patch to add a showModalDialog support for DumpRenderTree on Mac.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 18:00:07 PDT 2010


Prasad Tammana <prasadt at chromium.org> has asked  for review:
Bug 35350: DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Attachment 59319: Patch to add a showModalDialog support for DumpRenderTree on
Mac.
https://bugs.webkit.org/attachment.cgi?id=59319&action=review

------- Additional Comments from Prasad Tammana <prasadt at chromium.org>
This patch is the same as previous one reviewed by Darin.  I've addressed a few
non-mac platform specific issues identified by the build bots.	Specific
changes are:

1) Updated some platform specific expected output files.  In some cases,
deleted them where they are no longer different from the default ones.
2) sputnik tests pass on chromium as DRT on chromium has a default
implementation for showModalDialog.
3) Fix a logic bug in window-function-name-getter-precedence.html and
window-function-frame-getter-precedence.html to skip showModalDialog when its
undefined.


More information about the webkit-reviews mailing list