[webkit-reviews] review denied: [Bug 40613] The JSObjectSetProperty doesn't overwrite property flags. : [Attachment 58759] Fix v1

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 40613: The JSObjectSetProperty doesn't overwrite property flags.
https://bugs.webkit.org/show_bug.cgi?id=40613

Attachment 58759: Fix v1
https://bugs.webkit.org/attachment.cgi?id=58759&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
This has bad behaviour in a number of ways -- the unconditional use of delete
if the property exists will destroy the PIC and so hurt performance for cases
where the attributes are not being changed.

Additionally you get weird behaviour if have:

proto = {prop: "foo"}
o = Object.create(proto);

and do:
JSObjectSetProperty(o, "prop", ..., ...);

you will delete "prop" from proto, and then add "prop" to o.  Clearly this is
less than ideal.

:-(

--Oliver