[webkit-reviews] review canceled: [Bug 40607] Implement the sync DB API in workers : [Attachment 58744] patch #1: implement DatabaseSync::openDatabaseSync()

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607

Attachment 58744: patch #1: implement DatabaseSync::openDatabaseSync()
https://bugs.webkit.org/attachment.cgi?id=58744&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Michael, I changed patch #1 as we discussed (I think...). Basically, I moved
performOpenAndVerify() + some fields + simple getters for those fields from
Database to AbstractDatabase. I also moved all guid-related methods to
AbstractDatabase, but the plan is to move them to a separate class once this
patch is landed. I also made a trivial change to DatabaseTracker, in order to
remove the dependency on Database. I haven't changed the logic at all.

I can already see a few ways to clean up Database further, but I'll work on
those in separate patches.

All tests in storage/ passed.