[webkit-reviews] review granted: [Bug 40779] [Chromium] Perf regression following landing of HTML5 parser : [Attachment 59047] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 16:56:26 PDT 2010


Eric Seidel <eric at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40779: [Chromium] Perf regression following landing of HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40779

Attachment 59047: Patch
https://bugs.webkit.org/attachment.cgi?id=59047&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTML5TreeBuilder.h:86
 +	static bool isScriptingFlagEnabled(Frame* frame);
No need for the argument name.

WebCore/html/HTML5TreeBuilder.cpp:142
 +	if (tagName == styleTag || tagName == iframeTag || tagName == xmpTag ||
tagName == noembedTag || tagName == noframesTag || (tagName == noscriptTag &&
isScriptingFlagEnabled(frame)))
Can we wrap this line? :)

Looks good to me.  I'd like Adam to look too to make sure
scriptController->canExecuteScripts(NotAboutToExecuteScript) is the right
flavor of "can we script now" call.


More information about the webkit-reviews mailing list