[webkit-reviews] review granted: [Bug 40607] Implement the sync DB API in workers : [Attachment 59039] patch #2: Add the SQLException class
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 17 16:57:04 PDT 2010
Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607
Attachment 59039: patch #2: Add the SQLException class
https://bugs.webkit.org/attachment.cgi?id=59039&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/js/JSExceptionBase.cpp:65
+ return reinterpret_cast<ExceptionBase*>(pathException);
Why does this diff look so funny?
WebCore/page/DOMWindow.idl:733
+ attribute SQLExceptionConstructor SQLException;
Do you need to update the results of the tests that enumerate the global object
for all the ports?
WebCore/storage/SQLException.h:7
+ * version 2 of the License, or (at your option) any later version.
2.0? I thought we used 2.1.. Google usually contributes under BSD.
More information about the webkit-reviews
mailing list