[webkit-reviews] review granted: [Bug 40112] Database callbacks are made using the ScriptExecutionContext of the frame that owns the Database object, rather than that of the caller : [Attachment 58766] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40112: Database callbacks are made using the ScriptExecutionContext of the
frame that owns the Database object, rather than that of the caller
https://bugs.webkit.org/show_bug.cgi?id=40112

Attachment 58766: patch
https://bugs.webkit.org/attachment.cgi?id=58766&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Great!	Is there a way to test this change?

WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp: 
 +	args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec),
error));
How did we get rid of deprecatedGlobalObjectForPrototype(exec) here?  can we
get the right global object?

WebCore/bindings/scripts/CodeGeneratorV8.pm:2291
 +		@args = ();
We don't need a "my" here?