[webkit-reviews] review granted: [Bug 40797] [Qt] Decode images directly to QPixmap : [Attachment 59030] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 40797: [Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Attachment 59030: Patch
https://bugs.webkit.org/attachment.cgi?id=59030&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
LGTM, cq- as the patch in Qt is not available on gitorious yet and waiting for
final review.

A few questions:

 192	 else {
 193	     QImage img;
 194	     const bool imageLoaded = m_reader->read(&img);
 195	     if (imageLoaded) {
 196		 pixmap = QPixmap::fromImage(img);
 197		 pixmapLoaded = true;
 198	     }
 199	 }

So we do not support animations? gif etc? Can imageCount() be 0?