[webkit-reviews] review granted: [Bug 40649] Pull script line number from DocumentParser instead of pushing it to ScriptController : [Attachment 59017] Fix tab in ChangeLog

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40649: Pull script line number from DocumentParser instead of pushing it to
ScriptController
https://bugs.webkit.org/show_bug.cgi?id=40649

Attachment 59017: Fix tab in ChangeLog
https://bugs.webkit.org/attachment.cgi?id=59017&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Wow, this patch is GORGEOUS.

I would kinda like a comment here to explain the +1.  At least we only have one
+1 now though:
+    if (DocumentParser* parser = m_frame->document()->parser())
+	 return parser->lineNumber() + 1;

Also, do we need some sort of XML-based event handler test to test the fixed
line number handling for the XML parser?