[webkit-reviews] review requested: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 59031] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 59031: Patch
https://bugs.webkit.org/attachment.cgi?id=59031&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
> (From update of attachment 54927 [details])
> Looks pretty close.  There's one bogus code section though:  The offsetX /
offsetY computation that just loops up through the parent ScrollViews. There's
more complexity to converting to window coordinates than just adding in offsets
like that.  Fortunately you can just use contentsToWindow on the rect to
convert it.  This will work in the presence of transforms, unlike the code you
wrote.

Sweet. I have updated the patch to use contentsToWindow in order to convert the
update rect.

Thanks for the review!