[webkit-reviews] review denied: [Bug 40133] AX: need ListItemRole and PresentationalRole : [Attachment 58086] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 19:12:27 PDT 2010


Darin Adler <darin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 40133: AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Attachment 58086: patch
https://bugs.webkit.org/attachment.cgi?id=58086&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +Node* AccessibilityRenderObject::node() const
> +{
> +    if (!m_renderer) 
> +	   return 0;
> +    return m_renderer->node();
> +}

What is this function for? It's added in the patch and not used.

The patch otherwise seems great. review- because of the seemingly-unrelated
change.


More information about the webkit-reviews mailing list