[webkit-reviews] review denied: [Bug 40237] [Qt] QtWebKit exports WebCore symbols : [Attachment 58036] Patch to reduce visibility similar to the JavaScriptCore commit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 19:11:00 PDT 2010


Eric Seidel <eric at webkit.org> has denied Felix Geyer <debfx-webkit at fobos.de>'s
request for review:
Bug 40237: [Qt] QtWebKit exports WebCore symbols
https://bugs.webkit.org/show_bug.cgi?id=40237

Attachment 58036: Patch to reduce visibility similar to the JavaScriptCore
commit
https://bugs.webkit.org/attachment.cgi?id=58036&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please generate the patch from a WebKit checkout, and include a ChangeLog per
our contribution guidelines:
http://webkit.org/coding/contributing.html

webkit-patch upload
is one script which can help you make sure you're following the guildes.


More information about the webkit-reviews mailing list