[webkit-reviews] review granted: [Bug 40192] AX: link won't return linked element if URL contains # : [Attachment 58489] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 12 19:13:37 PDT 2010
Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 40192: AX: link won't return linked element if URL contains #
https://bugs.webkit.org/show_bug.cgi?id=40192
Attachment 58489: Patch
https://bugs.webkit.org/attachment.cgi?id=58489&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> linkURL.removeFragmentIdentifier();
> - if (m_renderer->document()->url() != linkURL)
> + KURL documentURL = m_renderer->document()->url();
> + documentURL.removeFragmentIdentifier();
> + if (documentURL != linkURL)
> return 0;
There's also a equalIgnoringFragmentIdentifier function in KURL.h that can be
used for cases like this.
More information about the webkit-reviews
mailing list