[webkit-reviews] review granted: [Bug 40389] make rietveld upload faster and avoid posting to bug on errors : [Attachment 58301] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 40389: make rietveld upload faster and avoid posting to bug on errors
https://bugs.webkit.org/show_bug.cgi?id=40389

Attachment 58301: Patch
https://bugs.webkit.org/attachment.cgi?id=58301&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I think you have a typo, but looks good otherwise.

WebKitTools/Scripts/webkitpy/common/net/bugzilla.py:274
 +	    def fetch_patch(url):
Normally we'd make this a private method.

WebKitTools/Scripts/webkitpy/common/net/bugzilla.py:275
 +		bugs = self._fetch_bug_ids_advanced_query(rietveld_queue_url)
rietveld_queue_url -> url?

WebKitTools/Scripts/webkitpy/common/net/bugzilla.py:276
 +		patches = self._fetch_bug(bugs[0]).in_rietveld_queue_patches()
Does in_rietveld_queue_patches cover r? too?