[webkit-reviews] review denied: [Bug 40393] HTML5 Parser: Fix fast/profiler tests that depend on event handler line numbers : [Attachment 58306] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40393: HTML5 Parser: Fix fast/profiler tests that depend on event handler
line numbers
https://bugs.webkit.org/show_bug.cgi?id=40393

Attachment 58306: Patch
https://bugs.webkit.org/attachment.cgi?id=58306&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/html/HTML5Tokenizer.cpp:105
 +	    if (scriptController)
I'm worried that constructTreeFromToken can cause script to run synchronously,
which could invalidate the |frame|, which would invalidate scriptController. 
Maybe we need a private helper function to get the script controller?

if (ScriptController* scriptController = script())
    scriptController->setEventHandlerLineNumber(...)