[webkit-reviews] review denied: [Bug 36359] Double clicking page's last editable inline element doesn't select a word. : [Attachment 57292] patch v8

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 36359: Double clicking page's last editable inline element doesn't select a
word.
https://bugs.webkit.org/show_bug.cgi?id=36359

Attachment 57292: patch v8
https://bugs.webkit.org/attachment.cgi?id=57292&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
LayoutTests/editing/selection/doubleclick-inline-first-last-contenteditable-exp
ected.txt:1
 +  here to double click, and there
Very confusing output.
Can you use the js-test-pre.js / js-test-post.js framework, and create a better
test case?

That would also avoid having to write your custom log() function.
WebCore/editing/TextIterator.cpp:275
 +	// FIXME: should support TextIteratorEndsAtEditingBoundary
You should file a bug for that, and refer to it here.

WebCore/editing/TextIterator.cpp:950
 +	: m_behavior(TextIteratorDefaultBehavior), m_node(0), m_positionNode(0)

Each initialization belongs in its own line.

WebCore/editing/TextIterator.cpp:955
 +	: m_behavior(behavior), m_node(0), m_positionNode(0)
Ditto.

WebCore/editing/TextIterator.h:187
 +	bool crossesEditingBoundary(Node* node) const;
You can omit the "node" name here.

WebCore/editing/TextIterator.h:188
 +	bool setCurrentNode(Node* node);
Ditto.