[webkit-reviews] review denied: [Bug 32856] querySelectorAll with "nth-child(3n+1), nth-child(3n)" : [Attachment 56335] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 23:07:30 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has denied Yoshiki Hayashi
<yhayashi at google.com>'s request for review:
Bug 32856: querySelectorAll with "nth-child(3n+1),nth-child(3n)"
https://bugs.webkit.org/show_bug.cgi?id=32856
Attachment 56335: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=56335&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
LayoutTests/fast/dom/SelectorAPI/nth-child.html:16
+ debug(i);
This should be removed, the expected.txt looks confusing.
LayoutTests/fast/dom/SelectorAPI/nth-child-expected.txt:27
+ blue
You might want to load the js-test-post.js file delayed (there are numerous
examples in existing tests how to do this), as the test output looks confusing:
blue
blue
white
..
Please fix these issues and resubmit.
More information about the webkit-reviews
mailing list