[webkit-reviews] review denied: [Bug 30708] ::first-letter inherits from ::after pseudo-element : [Attachment 57309] Proposed Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Yoshiki Hayashi
<yhayashi at google.com>'s request for review:
Bug 30708: ::first-letter inherits from ::after pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=30708

Attachment 57309: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=57309&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
LayoutTests/fast/css/first-letter-and-after-expected.txt:1
 +  Test to make sure :first-letter do not inherit from :after. If you see
"testAFTER", the test has passed.
I'm not seeing "testAFTER", but "test". Does the testcase actually work?

WebCore/rendering/RenderBlock.cpp:256
 +	// Intentionally not calling updateFirstLetter because it will be done
first thing in the morning in layout().
I hope it's also called in the afternoon... just leave it out. "Intentionally
not calling updateFirstLetter() because it's done in layout().