[webkit-reviews] review denied: [Bug 39204] schedule/unscheduleAll API in ResourceHandleMac : [Attachment 56220] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 23:01:30 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 39204: schedule/unscheduleAll API in ResourceHandleMac
https://bugs.webkit.org/show_bug.cgi?id=39204

Attachment 56220: proposed patch
https://bugs.webkit.org/attachment.cgi?id=56220&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r-, because of the layering violation.

I have no clue about this particular part of the code, but you could avoid
passing Page, by just querying Page* from the call site, and pass in a
SchedulePairHashSet* pointer to your scheduleAll/unscheduleAll functions.
Not sure if this design is good at all, other reviewers could comment better
than me.


More information about the webkit-reviews mailing list