[webkit-reviews] review granted: [Bug 42935] [MSVC] Ensure 4 byte alignment on ARM : [Attachment 62502] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 42935: [MSVC] Ensure 4 byte alignment on ARM
https://bugs.webkit.org/show_bug.cgi?id=42935

Attachment 62502: Patch
https://bugs.webkit.org/attachment.cgi?id=62502&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if COMPILER(MSVC)
> +#pragma pack(push)
> +#pragma pack(4)
> +#endif // COMPILER(MSVC)

I think having a comment on an endif that is only 2 lines away from the #if is
overkill!

> +#if COMPILER(MSVC)
> +#pragma pack(pop)
> +#endif // COMPILER(MSVC)

And even moreso here.