[webkit-reviews] review requested: [Bug 42933] Cleanup defines in Platform.h : [Attachment 62500] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 42933: Cleanup defines in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=42933

Attachment 62500: Patch
https://bugs.webkit.org/attachment.cgi?id=62500&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #2)
> (From update of attachment 62500 [details])
> > -#if PLATFORM(WIN)
> > +#if PLATFORM(WIN) && !OS(WINCE)
> 
> Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true?
I think this part of the change is wrong.
WinCE+GDI defines PLATFORM(WIN), so it is correct.

Cleaning up the PLATFORM() checks for WinCE is IMHO an other task. (e.g. There
a too many OS(WINCE) && !PLATFORM(QT))