[webkit-reviews] review denied: [Bug 42933] Cleanup defines in Platform.h : [Attachment 62500] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 24 12:40:23 PDT 2010


Darin Adler <darin at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 42933: Cleanup defines in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=42933

Attachment 62500: Patch
https://bugs.webkit.org/attachment.cgi?id=62500&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -#if PLATFORM(WIN)
> +#if PLATFORM(WIN) && !OS(WINCE)

Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I
think this part of the change is wrong.


More information about the webkit-reviews mailing list