[webkit-reviews] review granted: [Bug 41516] JavaInstanceV8 needs to push a local reference frame to avoid table overflow. : [Attachment 60364] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 41516: JavaInstanceV8 needs to push a local reference frame to avoid table
overflow.
https://bugs.webkit.org/show_bug.cgi?id=41516

Attachment 60364: Patch
https://bugs.webkit.org/attachment.cgi?id=60364&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This change is taxing the boundaries of my understanding of Java.  Ideally, the
ChangeLog would contain more information to help folks understand what problem
is being solved and how this patch goes about solving them.  I'm hesitating to
R+ this change, but on balance, it seems like the right thing to do.

WebCore/ChangeLog:8
 +	    No new tests.
sad face

WebCore/bridge/jni/v8/JavaInstanceV8.cpp:50
 +  #define NUM_LOCAL_REFS 64
Where does this number come from?