[webkit-reviews] review denied: [Bug 41697] [Chromium] Crash when re-entering message loop : [Attachment 60633] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 41697: [Chromium] Crash when re-entering message loop
https://bugs.webkit.org/show_bug.cgi?id=41697

Attachment 60633: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=60633&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/WebViewImpl.cpp:141
 +  static PageGroupLoadDeferrer* pageGroupLoadDeferrer = 0;
You don't need explicit initialization here.

WebKit/chromium/ChangeLog:5
 +	    [Chromium] Crash when re-entering message loop
Please provide more detailed comment including the description of the drawbacks
of this solution.

WebKit/chromium/src/WebViewImpl.cpp:191
 +	    ASSERT(pageGroupLoadDeferrer);
You may want to check in debug mode that PageGroup hasn't changed since
previous call to this method

WebKit/chromium/src/js/Tests.js:1862
 +	WebInspector.console.visible = true;
Use  WebInspector.showConsole instead.

WebKit/chromium/src/js/Tests.js:1896
 +	    function(callFrames) {
Please use evaluateInConsole_ instead of this custom code.

WebKit/chromium/src/js/Tests.js:1872
 +			function(commandResult) {
Use evaluateInConsole_ instead.