[webkit-reviews] review granted: [Bug 41608] DeviceOrientation should be renamed to DeviceOrientationController : [Attachment 60539] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 02:46:35 PDT 2010


Adam Barth <abarth at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 41608: DeviceOrientation should be renamed to DeviceOrientationController
https://bugs.webkit.org/show_bug.cgi?id=41608

Attachment 60539: Patch
https://bugs.webkit.org/attachment.cgi?id=60539&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/dom/DeviceOrientationController.h:38
 +	// FIXME: Add methods to start and stop the service.
This patch will make more sense once we do this FIXME.

It's not really controlling the DeviceOrientation, is it?  That would be kind
of awesome.  Instead, it's controlling the DeviceOrientation service, right?  I
guess the GeolocationController isn't controlling the geolocation either.  I
guess brevity is a virtue here and DeviceOrientationServiceController is too
long...

Anyway, not 100% cheesed about the name.


More information about the webkit-reviews mailing list