[webkit-reviews] review denied: [Bug 34019] Custom-written JavaScript parser : [Attachment 47711] Another attempt

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 34019: Custom-written JavaScript parser
https://bugs.webkit.org/show_bug.cgi?id=34019

Attachment 47711: Another attempt
https://bugs.webkit.org/attachment.cgi?id=47711&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I really don't like the top(-n) stuff.	I would much rather all were replaced
with pop(), etc.

I think if there isn't a performance hit it would be _much_ clearer to have all
code be of the form

GrammarStackItem rhs = pop();
GrammarStackItem lhs = pop();
push(new AddNode(lhs, rhs));

Or whatever, rather than 
top(-2) = new AddNode(top(-1), top(-2));
pop();