[webkit-reviews] review denied: [Bug 33630] SVG not rendered as background-image from data URI : [Attachment 47856] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 1 12:30:01 PST 2010
Eric Seidel <eric at webkit.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 33630: SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630
Attachment 47856: Patch v2
https://bugs.webkit.org/attachment.cgi?id=47856&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
FloatRect has a constructor which takes a point and a size. That would be
cleaner than using size.width() size.height().
"r" is not a very good variable name.
Are you sure that rect() isn't already implemented in Image.h anyway?
Why should draw() be used explicitly instead of renderSubtreeToImage changed?
More information about the webkit-reviews
mailing list