[webkit-reviews] review denied: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 47844] Repaint only the invalidated area after scrolling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 1 12:21:49 PST 2010


Dave Hyatt <hyatt at apple.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 47844: Repaint only the invalidated area after scrolling
https://bugs.webkit.org/attachment.cgi?id=47844&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This is not quite right.  Both fixed and absolute positioned objects can be
added to RenderView. so you can't just use the list as is like that.  I wasn't
suggesting that you change how you detected and added the objects.  The way you
did that in your old patch is still necessary.	The count just lets you not
keep a whole separate list, since you can walk the RenderView's list and check
if the object is fixed positioned (and if so use it).

Rename the variable in ScrollView to m_fixedObjectCount rather than
m_positionedObjectCount.


More information about the webkit-reviews mailing list