[webkit-reviews] review denied: [Bug 38008] [chromium] Skia needs to fade DragImages : [Attachment 54105] clean up changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 16:31:52 PDT 2010


David Levin <levin at chromium.org> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 38008: [chromium] Skia needs to fade DragImages
https://bugs.webkit.org/show_bug.cgi?id=38008

Attachment 54105: clean up changelog
https://bugs.webkit.org/attachment.cgi?id=54105&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- for swapping the x and y variable names.

WebCore/platform/chromium/DragImageChromiumSkia.cpp:79
 +	for (int x = 0; x < image->height(); ++x) {
y for height and x for width would be more typical. I thought the params passed
to getaddr32 were reversed and then realized it was the naming. 

WebKit/chromium/tests/DragImageTest.cpp: 
 +	// This is not implemented, so we don't do any output validation.
And why don't we do any validation now?

WebKit/chromium/ChangeLog:9
 +	    (WebCore::TEST):
This isn't really correct. It is typically the function name.

WebKit/chromium/ChangeLog:6
 +	    additional tests
This feels lacking. Perhaps it would be just as well to omit this text.


More information about the webkit-reviews mailing list