[webkit-reviews] review denied: [Bug 38227] [chromium] Don't expose filesystem paths on file drop : [Attachment 54470] Filter file:// URLs from event.dataTransfer.getData

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 38227: [chromium] Don't expose filesystem paths on file drop
https://bugs.webkit.org/show_bug.cgi?id=38227

Attachment 54470: Filter file:// URLs from event.dataTransfer.getData
https://bugs.webkit.org/attachment.cgi?id=54470&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
WebCore/ChangeLog:5
 +	    [Chromium] Filter out URLs with file:// scheme from text/uri-list
when dragging.
Can you update the bug title in order to be consistent with the line above.
Also, I think you could simply say "file scheme".

WebCore/platform/chromium/ClipboardChromium.cpp:170
 +		    if (protocolIs(uri, "file"))
Could you please add a comment for doing this?

WebCore/platform/chromium/ClipboardChromium.cpp:185
 +	    if (!m_dataObject->url.isEmpty() &&
!m_dataObject->url.isLocalFile()) {
ditto.

WebCore/platform/chromium/ClipboardChromium.cpp:321
 +	if (m_dataObject->url.isValid() && !m_dataObject->url.isLocalFile()) {
ditto.