[webkit-reviews] review denied: [Bug 38147] [chromium] WebKit API additions to support appcache in workers. : [Attachment 54362] add some WebKit:: namespace prefixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 16:37:06 PDT 2010


Dmitry Titov <dimich at chromium.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 38147: [chromium] WebKit API additions to support appcache in workers.
https://bugs.webkit.org/show_bug.cgi?id=38147

Attachment 54362: add some WebKit:: namespace prefixes
https://bugs.webkit.org/attachment.cgi?id=54362&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
And a small nit:

> Index: WebKit/chromium/src/WebWorkerBase.cpp

> +void WebWorkerBase::didCreateDataSource(WebFrame* frame, WebDataSource* ds)
> +{
> +    // Tell the loader to load the data into the 'shadow page'
synchronously,
> +    // so we can grab the resulting Document right after load.
> +   
static_cast<WebDataSourceImpl*>(ds)->setDeferMainResourceDataLoad(false);
> +}

'frame' is not used in this function, should be omitted.

Almost there.


More information about the webkit-reviews mailing list